Fix "Deprecated: Non-static method should not be called statically"

[TypicalFence]

When writing classes like in your examples:

use Jgut\Slim\Routing\Mapping\Annotation as JSR;

/**
 * @JSR\Router
 */
class Controller
{
    /**
     * @JSR\Route(pattern="/hello")
     */
    public function doSomething()
    {
    }
}

we would get errors like Deprecated: Non-static method should not be called statically, as a workaround we would just make all the methods static, which worked.

But we also had the problem that we wanted to write Controller Classes, which get a reference to the Container injected.

Because of this, I changed the format in which the class and method gets handed over to Slim, to the way to this section in the documentation describes how it should be done ("Class:method").

Also please note that we are using PHP 7.2.

[coveralls]

Coverage increased (+0.8%) to 99.847% when pulling 452872e on AlexFence:master into 0726a07 on juliangut:master.

[juliangut]

Why remove this typehint? $mapping is still an array

[TypicalFence]

I accidentally removed it while I was trying to get it working, I guess. I added it back in!

[juliangut]

Can you please review my comment and modify MappingTraitTest https://github.com/juliangut/slim-routing/blob/master/tests/Routing/Mapping/Driver/MappingTraitTest.php#L169 as you did with AnnotationDriverTest ?

[TypicalFence]

I made the changes you requested, did I miss anything?

[juliangut]

Thanks for the PR, new release available