Small review #8
Merged
Small review #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a couple of typos in comments
Suggestion not yet in PR:
In comments after a property, you mention e.g.,
# ERATV 4.10.14. Would it make sense to also add this in the RDF with a specific property? Then you can also access it in other applications to show to people acquainted with these IDs.Could be done as follows:
era:hasCurrentLimitation era:eratv-identifier "4.10.14" .whereera:eratv-identifieris a subPropertyOf dcterms:identifier, but with the extra knowledge that this identifier has been defined by eratv.