Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS Apple Silicon build #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ePirat
Copy link

@ePirat ePirat commented Jan 18, 2021

Fixes the build of the plugin for macOS arm64 (Apple Silicon).

@juliansader
Copy link
Owner

Thanks for helping! I see that you made a few changes to travis.yml. Does this mean that you successfully built the ARM version on Travis instead of Appveyor?

@ePirat
Copy link
Author

ePirat commented Jan 24, 2021

I did not look at Appveyor at all, I am not really familiar and had no idea it could be used for macOS builds. I've only changed the travis command because it was the only place I found where a build command was found. If you want I can help set up proper macOS builds for x86_64, ARM, Universal using either Travis or GitHub Actions as those two I am quite familiar with and could do it easily.

Ideally the project would have a proper build system instead of just some compiler command somewhere, to help with portability and easily adapting things for different architectures.

@gnai
Copy link

gnai commented Aug 17, 2021

Does this mean it should work flawlessly on the M1 machines ?
Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants