Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when using velocity.ui in a project that needs to support IE7 #246

Closed
tkallsen opened this issue Aug 14, 2014 · 3 comments
Closed
Labels

Comments

@tkallsen
Copy link

When including velocity and velocity.ui and testing with IE7, an error will be thrown because velocity.ui will try to write to the console (which is undefined) complaining about that velocity.js is not loaded ("Velocity UI Pack: Velocity must be loaded first. Aborting.").

Our current fix locally in our project is just to test for if the console is present:

if ((!Container.Velocity || !Container.Velocity.Utilities) && typeof (console) != "undefined") {
console.log("Velocity UI Pack: Velocity must be loaded first. Aborting.");

 return;

}

@julianshapiro
Copy link
Owner

Thank you very much. I will fix this today.

@tkallsen
Copy link
Author

That is a very quick turnaround ;) Thanks.

@julianshapiro
Copy link
Owner

Please update to the latest version and let me know how everything is working.

Rycochet pushed a commit that referenced this issue Aug 3, 2020
Fixes CommonJS module loading. Closes #232. Closes #238.

Allow animating with the raw utility function (Velocity) instead of its
property (Velocity.animate), e.g. $.Velocity(element, propertiesMap,
options);

Copy over _cacheValues option for the UI pack. Closes #239.

Reverts Velocity.mock to original (asynchronous) behavior. Closes #237.

Fixes IE7 error throwing in UI pack. Closes #246.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants