Passing undefined as second arg causes an exception

[Rycochet]

If you pass undefined as the second argument to velocity it throws an error related to line 2060 -

if (!Type.isArray(arguments[i]) && (/fast|normal|slow/i.test(arguments[i].toString()) || /^\d/.test(arguments[i]))) {

Basically this means that using a wrapper function with an optional second arg can't pass that second arg straight through without processing it in some way.

It might be somewhat safer (and possibly quicker) to do something like this (forcing the formatting, rather than matching any string with the correct words etc too) -

if (arguments[i] !== undefined && !Type.isArray(arguments[i]) && /^(fast|normal|slow|\d+)$/i.test(arguments[i].toString())) {

Though I'd be tempted to manually check if it's a number or matching string specifically, rather than simply excluding an array.

jsFiddle - http://jsfiddle.net/Rycochet/65xCP/6/ (since I seem to always forget the things :-P )

[julianshapiro]

Thanks, Robyn. I'll have this fixed in the next version. Might be a bit before that's released, though, as my update frequency will henceforth depend on the reporting of critical bugs.

P.S. I was unnecessarily calling .toString() for IE8 error prevention. Turns out it's only .match()/.replace() that throw errors on non-strings -- not .test().

[Rycochet]

I did wonder about the .toString, but couldn't remember where implicit conversion happened so just left it in - fortunately I only need IE9+ at work, so can ignore browser bugs like that ;-)

You could always use a separate branch for working on, then only update master when you want a new release - I keep meaning to do things like that myself, but still too many changes (and not publicly launched either for that matter) ;-)

Btw, in Scotland, Robin is the boys name and Robyn is the girls name, it's only been Americanised in the last couple of decades... Gah, now I feel old(er) :-P

[julianshapiro]

Please check, make sure it works, and get back to me. Thanks!

[Rycochet]

Doh, just realised I hadn't replied - yep, fixed and working :-)