refactor: Improved web implementation #979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koji-1009
changed the title
|
@koji-1009 I will see if I can cherry-pick your commits into the branch for the next beta release. I also have some small improvements as well, which we could use. |
Merged
|
@koji-1009 I have cherry-picked one of your commits in f31b03d I also had the changes for bumping web to 0.5.1 and the change to the HTMLElement constructor locally, due to a different bugfix in the next beta, so I did not cherry-pick those commits from your branch. The only things I added on top was adding two missing I will close this PR, as #1005 includes the cherry-pick. Thanks a lot for this work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added following fix.
Thanks for the useful library.