fix: Release barcode scanner when not in use #991
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 16, 2024
navaronbracke
force-pushed
the
android_strict_mode
branch
from
99f4bb6
to
39e2cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: test with StrictMode & returnImage: true, since those code paths have changed
TODO: do the same fix for iOS
TODO: remove the assert for analyzeImage()
TODO: let analyzeImage() take the formats from the controller
This PR updates the Android implementation to release the BarcodeScanner when it is no longer used.
It also reflows some blocks of code that could have used early returns and the like.
Fixes #988