Skip to content

Commit

Permalink
Revert "30FPS: Fix crash conflict in FF7 with ESUI mod (#592)" (#596)
Browse files Browse the repository at this point in the history
  • Loading branch information
tangtang95 committed Sep 9, 2023
1 parent ed3bc6f commit 521c768
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 15 deletions.
2 changes: 1 addition & 1 deletion src/ff7/battle/animations.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1274,7 +1274,7 @@ namespace ff7::battle
// Effect60 related
patch_multiply_code<WORD>(ff7_externals.battle_sub_425E5F + 0x3A, battle_frame_multiplier);

patch_multiply_code_if_as_expected<WORD>(ff7_externals.battle_sub_5BCF9D + 0x3A, battle_frame_multiplier, 0x15);
patch_multiply_code<WORD>(ff7_externals.battle_sub_5BCF9D + 0x3A, battle_frame_multiplier);
patch_code_byte(ff7_externals.battle_sub_5BD050 + 0x1DC, 0x2 - battle_frame_multiplier / 2);
patch_code_byte(ff7_externals.battle_sub_5BD050 + 0x203, 0x2 - battle_frame_multiplier / 2);

Expand Down
14 changes: 0 additions & 14 deletions src/patch.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,20 +69,6 @@ void patch_divide_code(uint32_t offset, int multiplier)
// TODO Add assertion
}

template<typename T>
void patch_multiply_code_if_as_expected(uint32_t offset, int multiplier, T expected_value)
{
T current_value = *(T *)offset;
if (current_value == expected_value)
{
patch_multiply_code<T>(offset, multiplier);
}
else
{
ffnx_warning("%X: Unexpected value in offset (expected: %X, found: %X)\n", offset, expected_value, current_value);
}
}

void memcpy_code(uint32_t offset, void *data, uint32_t size);
void memset_code(uint32_t offset, uint32_t val, uint32_t size);

Expand Down

0 comments on commit 521c768

Please sign in to comment.