Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ FF7 ] Aerith Eye Texture #589

Closed
KuraudoXS opened this issue Sep 5, 2023 · 2 comments
Closed

[ FF7 ] Aerith Eye Texture #589

KuraudoXS opened this issue Sep 5, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request external-fix It needs an external tool to be fixed
Milestone

Comments

@KuraudoXS
Copy link

KuraudoXS commented Sep 5, 2023

Buried in the code we can notice there was an instance where Aerith would change eye texture in the Sleeping Forest and Cid would change mouth texture in the Gondola, the Cid mouth texture should be present in PC version but achievable only by updating model IIRC.

While the Aerith eye texture 3 is not in PC version at all and would need a new logic in within the engine itself most likely.
See below field name and the exact moment in game.

  1. "Aerith's eye texture 3 used when she is laughing during Cloud's dream after the Temple of Ancients." (5:04:37 - https://youtu.be/ub0qHDFZayE?feature=shared&t=18277 ) (slfrst_1 )
  2. "Cid's mouth texture 2 (open mouth) is used in the scene where he is with Cloud in Gold Saucer's Round Square." (1:19:33 - https://youtu.be/2hAg9tzCHpk?feature=shared&t=4773 ) ( bwhlin and bwhil2 )

Could be nice to have this petit détail restored.

Source: https://tcrf.net/Final_Fantasy_VII
Eye Texture 3: AUHC.bmp https://drive.google.com/file/d/1Naebiqq1MqsXeiqIz5GmtFWOc5xA0fNa/view?usp=sharing

@KuraudoXS KuraudoXS added the bug Something isn't working label Sep 5, 2023
@julianxhokaxhiu julianxhokaxhiu added the help wanted Extra attention is needed label Sep 5, 2023
@KuraudoXS KuraudoXS changed the title [ FF7 ] Aerith & Cid Textures [ FF7 ] Aerith Eye Texture Sep 5, 2023
@julianxhokaxhiu
Copy link
Owner

I had a quick look at this issue and so far I found the following info around it:

Since the game has no room for custom eye textures, I think the fix has probably to happen in the field data itself, using a custom Aerith model and using a custom model to fix the eye texture.

I can't see any other way to fix it via code as there's nothing to fix actually. Open for feedback, I'll change the status of the issue in the meantime.

@julianxhokaxhiu julianxhokaxhiu added external-fix It needs an external tool to be fixed and removed bug Something isn't working labels Sep 17, 2023
@julianxhokaxhiu julianxhokaxhiu added enhancement New feature or request and removed help wanted Extra attention is needed labels Dec 16, 2023
@julianxhokaxhiu julianxhokaxhiu added this to the 1.17.0 milestone Dec 16, 2023
@julianxhokaxhiu julianxhokaxhiu self-assigned this Dec 16, 2023
@julianxhokaxhiu
Copy link
Owner

First part is now done in code. The second part has to be provided externally with a mod.

If you enable trace_opcodes = true you'll now see this message that will give you a hint for which custom eye texture the game is trying to load:

[00007252] TRACE: opcode[KAWAI]: num_params:7,subcode:0x0,left_eye_index:2,right_eye_index:2,mouth_index:0
[00007252] TRACE: opcode[KAWAI]: Custom left eye texture not found: direct/flevel/c_eye2_2.TEX
[00007252] TRACE: opcode[KAWAI]: Custom right eye texture not found: direct/flevel/c_eye2r_2.TEX

julianxhokaxhiu added a commit that referenced this issue Dec 16, 2023
julianxhokaxhiu added a commit that referenced this issue Dec 16, 2023
julianxhokaxhiu added a commit that referenced this issue Dec 16, 2023
Make the whole approach more solid. Additionally introduce a reset state when index 0 is picked.

Related #589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request external-fix It needs an external tool to be fixed
Projects
None yet
Development

No branches or pull requests

2 participants