Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Add CMakePresets.json #554

Merged
merged 12 commits into from
Mar 18, 2023
Merged

Conversation

MaKiPL
Copy link
Contributor

@MaKiPL MaKiPL commented Mar 17, 2023

CMakeSettings.json might be still needed for VS to correctly understand the builds with CMake. This file is completely ignored on CLion though

Fixes #552

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Mar 17, 2023
@julianxhokaxhiu julianxhokaxhiu added this to the 1.16.0 milestone Mar 17, 2023
@julianxhokaxhiu julianxhokaxhiu linked an issue Mar 17, 2023 that may be closed by this pull request
@julianxhokaxhiu julianxhokaxhiu changed the title Implemented #552 ; Not removing CMakeSettings.json yet CMake: Add CMakePresets.json Mar 17, 2023
julianxhokaxhiu and others added 11 commits March 17, 2023 17:49
- Bump version to 6 and set CMake 3.25 as minimum requirement
- Rename default configurePreset to x86-Debug
- Re-order presets blocks
- Set x86-RelWithDebInfo as default build preset
No more required since it will be governed by CMakePresets.json
Remove intellisense settings from c_cpp_properties.json
This will replace the setting in settings.json plus define a set of standards that every other IDE can make use of
Additionally streamline some configurations
@julianxhokaxhiu julianxhokaxhiu merged commit 50e182c into julianxhokaxhiu:master Mar 18, 2023
@julianxhokaxhiu
Copy link
Owner

Thank you!

@MaKiPL
Copy link
Contributor Author

MaKiPL commented Mar 18, 2023

Thank you kindly for all your work to fullfil the preset file completely and integrate into the project. Now it's time for smooth snowboard implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Replace CMakeSettings.json with CMakeProfiles.json
2 participants