-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: Add CMakePresets.json #554
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…- might be still needed for older VS
julianxhokaxhiu
changed the title
Implemented #552 ; Not removing CMakeSettings.json yet
CMake: Add CMakePresets.json
Mar 17, 2023
- Bump version to 6 and set CMake 3.25 as minimum requirement - Rename default configurePreset to x86-Debug - Re-order presets blocks - Set x86-RelWithDebInfo as default build preset
No more required since it will be governed by CMakePresets.json
Remove intellisense settings from c_cpp_properties.json
This will replace the setting in settings.json plus define a set of standards that every other IDE can make use of
Additionally streamline some configurations
julianxhokaxhiu
approved these changes
Mar 17, 2023
Thank you! |
Thank you kindly for all your work to fullfil the preset file completely and integrate into the project. Now it's time for smooth snowboard implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMakeSettings.json might be still needed for VS to correctly understand the builds with CMake. This file is completely ignored on CLion though
Fixes #552
ACKs