Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF8: Add more overridable textures for Worldmap + fixes #584

Merged
merged 1 commit into from
Jul 23, 2023
Merged

FF8: Add more overridable textures for Worldmap + fixes #584

merged 1 commit into from
Jul 23, 2023

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Jul 21, 2023 •
edited

Summary

  • Adding ability to override textures from wmset section 39 (rails and roads), 40 and 42 (vehicles).
  • Restore ability to mod "texl" textures, even with ff8_worldmap_internal_highres_textures option enabled. + bug fixes
  • Add save_textures_legacy to save texture in legacy format instead of recommended one
  • Fixes [ FF8 DE NV ] Cannot enter worldmap #565
  • Texture reload hack mini optimization on worldmap

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@myst6re myst6re force-pushed the feature/ff8-wm-external-texture-2 branch 5 times, most recently from 0c6b11e to 11eaeec Compare July 22, 2023 20:53
@myst6re myst6re marked this pull request as ready for review July 22, 2023 20:55
@myst6re myst6re force-pushed the feature/ff8-wm-external-texture-2 branch from 11eaeec to 97b192b Compare July 22, 2023 20:55
myst6re
myst6re commented Jul 22, 2023
View reviewed changes
src/cfg.cpp Show resolved Hide resolved
@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Jul 23, 2023
@julianxhokaxhiu julianxhokaxhiu added this to the 1.16.0 milestone Jul 23, 2023
julianxhokaxhiu
julianxhokaxhiu reviewed Jul 23, 2023
View reviewed changes
src/ff8/vram.cpp Outdated Show resolved Hide resolved
@julianxhokaxhiu julianxhokaxhiu added the bug Something isn't working label Jul 23, 2023
@myst6re myst6re force-pushed the feature/ff8-wm-external-texture-2 branch from 97b192b to c5697ad Compare July 23, 2023 14:56
@myst6re
Copy link
Contributor Author

myst6re commented Jul 23, 2023

Ready!

@myst6re myst6re force-pushed the feature/ff8-wm-external-texture-2 branch 2 times, most recently from 2d9da2c to 20e0a26 Compare July 23, 2023 16:07
@myst6re
FF8: Add more overridable textures for Worldmap + fixes when external…
9bce9e9 
… texture and internal high res worldmap is used
@myst6re myst6re force-pushed the feature/ff8-wm-external-texture-2 branch from 20e0a26 to 9bce9e9 Compare July 23, 2023 16:09
@julianxhokaxhiu julianxhokaxhiu merged commit e521213 into julianxhokaxhiu:master Jul 23, 2023
1 check passed
@julianxhokaxhiu
Copy link
Owner

Thanks a lot :)

@myst6re myst6re deleted the feature/ff8-wm-external-texture-2 branch July 23, 2023 18:00
@julianxhokaxhiu julianxhokaxhiu linked an issue Sep 11, 2023 that may be closed by this pull request
[ FF8 ] Custom texture override #29
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianxhokaxhiu julianxhokaxhiu julianxhokaxhiu approved these changes

Assignees

@myst6re myst6re

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

[ FF8 ] Custom texture override [ FF8 DE NV ] Cannot enter worldmap
2 participants
@myst6re @julianxhokaxhiu