Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clarity of data_drive usage #590

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

eve-atum
Copy link
Contributor

@eve-atum eve-atum commented Sep 6, 2023

Summary

Provide instruction on proper use of data_drive directive in FF8

Motivation

I choked on it tonight figuring "F" was good enough, then Windows barfed on me for attempting "F:\"

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@julianxhokaxhiu
Copy link
Owner

Thanks for the PR! I updated the text to make it more simple to be understood as well as follow the format of the other flags. Would this work for you?

@julianxhokaxhiu julianxhokaxhiu added the meta Anything non-code related label Sep 6, 2023
@julianxhokaxhiu julianxhokaxhiu added this to the 1.17.0 milestone Sep 6, 2023
@eve-atum
Copy link
Contributor Author

eve-atum commented Sep 6, 2023

Works for me, ship it :)

@julianxhokaxhiu julianxhokaxhiu merged commit 4be2a74 into julianxhokaxhiu:master Sep 6, 2023
1 check passed
@julianxhokaxhiu
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Anything non-code related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants