Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF8: Fix battle stage texture dump + option to use music files from remastered #594

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Sep 8, 2023

Summary

Fix battle stage texture dump with save_textures on.

option to use music files from remastered => if you extract the ogg files from remastered archives, you obtain files named like:

  • 008s-antena.ogg
  • 018s-julia.ogg
    It is the same format as the original game, but the extension is replaced from sgt to ogg. Also this does not use xg files naming

Motivation

I expected at first that Roses and Wine mod was using the same file name pattern than the original game.
That's not the case, we need to maintain a list of filename, that I don't want to.

But as a quickwin I can add the option for users who want to import oggs files from the remastered version to the 2013 version.

ACKs

  • I have updated the Changelog.md file
  • N/A I did test my code on FF7
  • I did test my code on FF8

…ic. Improving save textures for battle stages
@myst6re myst6re force-pushed the feature/ff8-remastered-oggs-to-2013-version branch from e832a30 to 51a2d28 Compare September 8, 2023 22:17
@myst6re myst6re marked this pull request as ready for review September 8, 2023 22:17
@julianxhokaxhiu julianxhokaxhiu added bug Something isn't working enhancement New feature or request labels Sep 9, 2023
@julianxhokaxhiu julianxhokaxhiu added this to the 1.17.0 milestone Sep 9, 2023
@julianxhokaxhiu julianxhokaxhiu merged commit ed3bc6f into julianxhokaxhiu:master Sep 9, 2023
1 check passed
@julianxhokaxhiu
Copy link
Owner

Thank you!

@julianxhokaxhiu julianxhokaxhiu linked an issue Sep 11, 2023 that may be closed by this pull request
7 tasks
@myst6re myst6re deleted the feature/ff8-remastered-oggs-to-2013-version branch November 3, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ FF8 ] Custom texture override
2 participants