FF7: Refactor 60FPS battle menu fix and fix ESUI compatibility #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangtang95
changed the title
julianxhokaxhiu
added
bug
julianxhokaxhiu
approved these changes
Sep 9, 2023
|
Thanks a lot for trying to find the best fix around this :) I agree the workaround is not the best but the condition around it is still FFNx related somehow so I'm fine with it. Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #592 and #593. This refactoring of battle menu 60fps fix follows the approach used in 30fps. It requires less patches and it should give better results in compatibility and coherence.
Also in the second commit I put a workaround for 30 fps + ESUI. I am not really a fan of it, but it does the job.
ACKs