FF7: Fix Bahamut Zero and Supernova not displaying correctly with lighting #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianxhokaxhiu
changed the title
julianxhokaxhiu
approved these changes
Sep 16, 2023
julianxhokaxhiu
changed the title
Sure, no problem. Thanks! |
|
Thank you! |
julianxhokaxhiu
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed Bahamut Zero and Supernova not displaying correctly when lighting enabled. The lighting shader assumes an input with valid normals. So for any model that has no valid normals I changed it to fallback to the standard shader.
Motivation
Because it's time to have a bug-free lighting mode from start to finish :)
ACKs