FF7: Implemented GPU-based original game lighting that better matches PSX version #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosmosXIII
force-pushed
the
gpuBasedOriginalLighting
branch
3 times, most recently
from
1a1c1e3
to
4b84338
Compare
julianxhokaxhiu
requested changes
Sep 24, 2023
CosmosXIII
force-pushed
the
gpuBasedOriginalLighting
branch
5 times, most recently
from
ce365b8
to
71f33f0
Compare
julianxhokaxhiu
approved these changes
Sep 26, 2023
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I re-implemented the original lighting done by the game in the shaders instead of the original CPU-based implementation.
In doing so I found that the light directions used by the game were inverted compared to the PSX version, so the new modes fix that too. The new modes better match better the PSX version lighting but there are small differences in contrast. Part of this is due to FFNx normal auto-calculation so those may not fully match.
Motivation
To make people happy. Also, if we end up doing smooth skinning, doing lighting on the GPU is necessary so this paves the path for that.
ACKs