Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF7: Fix Widescreen glitches for Bahamut Zero and Pollensalta #613

Merged

Conversation

tangtang95
Copy link
Contributor

Summary

Fix widescreen glitches (related to #474) for:

  • Bahamut Zero stars background positioning and size
  • Pollensalta cold breath attack: moving background and moving white dots

Regarding Pollensalta fix for the moving background size: this only works when in 30/60fps mode because I used a function hooked only when in 60 fps mode. I don't think there is other way to do it, but I think the correct solution should be to fix the texture page which I suppose it is inside files with .s as extension (in this case, special/hubuki/kemu.s). So I left the solution for 30/60fps just as a temporary fix.

Motivation

I don't know why either

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@julianxhokaxhiu julianxhokaxhiu added the bug Something isn't working label Oct 1, 2023
@julianxhokaxhiu julianxhokaxhiu added this to the 1.17.0 milestone Oct 1, 2023
@julianxhokaxhiu julianxhokaxhiu merged commit fd45903 into julianxhokaxhiu:master Oct 1, 2023
1 check passed
@julianxhokaxhiu
Copy link
Owner

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants