Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF8: Add support for palette changes in external textures + optimizations #617

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Oct 22, 2023

Summary

  • Support for dynamic palette changes of the same texture.
  • Separation of texture identification code and texture modding code
  • code to open images (PNG or bimg supported formats) is moved outside the renderer
  • Optimization of mod (and game!) texture loading time

Motivation

Support for dynamic palette changes of the same texture.

For example the minimap in the worldmap module.
2023-10-22 22_15_53-Window
2023-10-22 22_16_08-Window

Separation of texture identification code and texture modding code

In the future we want to bring at least compatibility with the remaster. Separating texture identification part permit reuse and clarity.

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

src/ff8.h Outdated Show resolved Hide resolved
src/image/tim.cpp Outdated Show resolved Hide resolved
@myst6re myst6re force-pushed the feature/ff8-paletted-textures branch 6 times, most recently from 2a7a954 to 84552b8 Compare November 1, 2023 18:09
@myst6re myst6re force-pushed the feature/ff8-paletted-textures branch 2 times, most recently from b560278 to d6525a4 Compare November 1, 2023 21:58
@myst6re myst6re force-pushed the feature/ff8-paletted-textures branch from d6525a4 to 1e29caa Compare November 1, 2023 22:31
@myst6re myst6re marked this pull request as ready for review November 1, 2023 22:32
@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Nov 1, 2023
@julianxhokaxhiu julianxhokaxhiu added this to the 1.17.0 milestone Nov 1, 2023
@julianxhokaxhiu
Copy link
Owner

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@julianxhokaxhiu julianxhokaxhiu merged commit 639ec28 into julianxhokaxhiu:master Nov 1, 2023
1 check passed
@julianxhokaxhiu
Copy link
Owner

Thank you!

@julianxhokaxhiu julianxhokaxhiu linked an issue Nov 1, 2023 that may be closed by this pull request
7 tasks
@myst6re myst6re deleted the feature/ff8-paletted-textures branch November 3, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ FF8 ] Custom texture override
2 participants