Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF8: Fix intro credits unsync #634

Merged
merged 1 commit into from
Jan 10, 2024
Merged

FF8: Fix intro credits unsync #634

merged 1 commit into from
Jan 10, 2024

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Jan 9, 2024 •
edited

Summary

The intro credits (before the main menu) is not synchronized with the background music.

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@myst6re myst6re force-pushed the feature/ff8-fix-intro-credits-unsync branch 4 times, most recently from 66b4539 to 6a0806c Compare January 9, 2024 23:55
@myst6re myst6re marked this pull request as ready for review January 10, 2024 00:01
@julianxhokaxhiu julianxhokaxhiu added the bug Something isn't working label Jan 10, 2024
@julianxhokaxhiu julianxhokaxhiu added this to the 1.17.0 milestone Jan 10, 2024
julianxhokaxhiu
julianxhokaxhiu reviewed Jan 10, 2024
View reviewed changes
docs/shortcuts.md Outdated Show resolved Hide resolved
julianxhokaxhiu
julianxhokaxhiu reviewed Jan 10, 2024
View reviewed changes
docs/shortcuts.md Outdated Show resolved Hide resolved
julianxhokaxhiu
julianxhokaxhiu requested changes Jan 10, 2024
View reviewed changes
Copy link
Owner

@julianxhokaxhiu julianxhokaxhiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things to be changed, but overall looks good, thanks :)

@myst6re myst6re force-pushed the feature/ff8-fix-intro-credits-unsync branch from 6a0806c to 4c4a4b0 Compare January 10, 2024 22:14
@myst6re myst6re marked this pull request as draft January 10, 2024 22:24
@myst6re myst6re marked this pull request as ready for review January 10, 2024 22:54
@julianxhokaxhiu julianxhokaxhiu changed the title FF8: fix intro credits unsync FF8: Fix intro credits unsync Jan 10, 2024
@julianxhokaxhiu julianxhokaxhiu merged commit 0cc1edb into julianxhokaxhiu:master Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianxhokaxhiu julianxhokaxhiu julianxhokaxhiu approved these changes

Assignees

@myst6re myst6re

Labels
bug Something isn't working
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@myst6re @julianxhokaxhiu