Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF7: Minor widescreen and external mesh fixes #635

Merged
merged 1 commit into from
Jan 11, 2024
Merged

FF7: Minor widescreen and external mesh fixes #635

merged 1 commit into from
Jan 11, 2024

Conversation

CosmosXIII
Copy link
Contributor

Summary

This PR fixes the following bugs:

  • External mesh only working when 60 fps and lighting enabled
  • Draw calls being omitted when rect cache max value is exceeded
  • Widescreen scrolling stopping one pixel too early

Motivation

To make this world a better place. Also for rainforest conservation purposes.

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@julianxhokaxhiu julianxhokaxhiu added the bug Something isn't working label Jan 11, 2024
@julianxhokaxhiu julianxhokaxhiu added this to the 1.17.0 milestone Jan 11, 2024
@julianxhokaxhiu julianxhokaxhiu merged commit 3857d23 into julianxhokaxhiu:master Jan 11, 2024
1 check passed
@julianxhokaxhiu
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianxhokaxhiu julianxhokaxhiu julianxhokaxhiu approved these changes

Assignees

@CosmosXIII CosmosXIII

Labels
bug Something isn't working
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CosmosXIII @julianxhokaxhiu