Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF7: New camera control in field mode using the right stick #637

Merged
merged 1 commit into from Jan 13, 2024
Merged

FF7: New camera control in field mode using the right stick #637

merged 1 commit into from Jan 13, 2024

Conversation

CosmosXIII
Copy link
Contributor

@CosmosXIII CosmosXIII commented Jan 13, 2024 •
edited

Summary

This PR adds the functionality to scroll the camera with the right analog stick. The camera goes back smoothly to it's usual position once the analog stick is released.

This PR also has some other minor fixes.

  • Fixes the problems raised in [ FF7 ] Battle camera control bugs #460 -> was not able to reproduce the bugs but this should be safer than before
  • Reduced lighting specular because it was too washed-out in some places

Motivation

Because we need more rainforest, not less, I'm serious.

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Jan 13, 2024
@julianxhokaxhiu julianxhokaxhiu added this to the 1.17.0 milestone Jan 13, 2024
@julianxhokaxhiu julianxhokaxhiu linked an issue Jan 13, 2024 that may be closed by this pull request
[ FF7 ] Battle camera control bugs #460
Closed
@julianxhokaxhiu julianxhokaxhiu changed the title FF7: Implemented right analog stick camera scrolling controls in field mode FF7: New camera control in field mode using the right stick Jan 13, 2024
@julianxhokaxhiu julianxhokaxhiu merged commit 2f1fb4e into julianxhokaxhiu:master Jan 13, 2024
1 check passed
@julianxhokaxhiu
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianxhokaxhiu julianxhokaxhiu julianxhokaxhiu approved these changes

Assignees

@CosmosXIII CosmosXIII

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

[ FF7 ] Battle camera control bugs
2 participants
@CosmosXIII @julianxhokaxhiu