Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF8: Various enhancements and fixes #650

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Feb 4, 2024

Summary

  • Fix gamepad icons not displayed
  • Use libPNG to decode PNGs, instead of bimg
  • Use DirectXTex to decode DDS and decompress only the relevant lod for faster loading
  • Minimize memory allocations with external textures to allow bigger textures and prevent game crashes (the game is limited to 2GB if not patched, and 4GB if patched, due to its x86 nature)

Motivation

Fix things

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@myst6re myst6re force-pushed the feature/ff8-optimize-external-texture-loading branch from 7472230 to f315bef Compare February 4, 2024 17:42
vcpkg.json Outdated Show resolved Hide resolved
@myst6re myst6re force-pushed the feature/ff8-optimize-external-texture-loading branch from f315bef to 24ef66a Compare February 4, 2024 18:34
@myst6re myst6re marked this pull request as ready for review February 4, 2024 20:28
@myst6re
Copy link
Contributor Author

myst6re commented Feb 4, 2024

Ready! I made 4 different commits, one for each subject, you can read them separatly to make the review simpler.

@julianxhokaxhiu julianxhokaxhiu added bug Something isn't working enhancement New feature or request labels Feb 4, 2024
@julianxhokaxhiu julianxhokaxhiu added this to the 1.18.0 milestone Feb 4, 2024
CMakePresets.json Outdated Show resolved Hide resolved
@myst6re myst6re force-pushed the feature/ff8-optimize-external-texture-loading branch from 4c9fa4d to a80956e Compare February 4, 2024 20:51
@julianxhokaxhiu julianxhokaxhiu changed the title FF8: Optimize external texture loading + Fix gamepad icons in Zell Limit Break FF8: Various enhancements and fixes Feb 4, 2024
@julianxhokaxhiu julianxhokaxhiu merged commit 681beda into julianxhokaxhiu:master Feb 4, 2024
@julianxhokaxhiu
Copy link
Owner

Thank you!

@myst6re myst6re deleted the feature/ff8-optimize-external-texture-loading branch March 14, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants