FF8: Update metadata file when a save file is created #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myst6re
force-pushed
the
fix/ff8-prevent-lost-save
branch
2 times, most recently
from
6be58ad
to
2682497
Compare
|
Also added a patch for a faster CI on forks, see succesful build here: https://github.com/myst6re/FFNx/actions/runs/7908320981/job/21587237081 |
julianxhokaxhiu
previously approved these changes
Feb 15, 2024
…nt save file loss
myst6re
force-pushed
the
fix/ff8-prevent-lost-save
branch
from
2682497
to
7339041
Compare
julianxhokaxhiu
previously approved these changes
Feb 15, 2024
|
Something is weird, not sure why but despite installing CMake 3.28.3, the version 3.27.9 is detected while this was not happening before. I have to find out why, but I'll work on this later. Thanks for now, LGTM! |
julianxhokaxhiu
approved these changes
Feb 15, 2024
julianxhokaxhiu
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewrite metadata file when a save file is created to prevent save file loss.
Currently the metadata file is updated when the game is closed. Some users experienced save file loss, maybe because the metadata file was not updated correctly and the ff8 launcher removed the save files which were detected as invalid.
Motivation
Losing your save is very serious situation, I never finished the game Child Of Light because Ubisoft devs do not understand the concept of redundancy and do not let you create several saves. Crash, lost hours, cry a lot, bargain, accept.
ACKs