FF8: vibration option in main menu #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myst6re
force-pushed
the
feature/ff8-vibration-option-in-main-menu
branch
4 times, most recently
from
75c8439
to
cb92f4c
Compare
|
If no vibrate capability |
myst6re
force-pushed
the
feature/ff8-vibration-option-in-main-menu
branch
2 times, most recently
from
c6ac4d9
to
76bab11
Compare
|
Can you please rebase and update the changelog? Thanks! |
myst6re
force-pushed
the
feature/ff8-vibration-option-in-main-menu
branch
from
76bab11
to
d7d1ac5
Compare
myst6re
force-pushed
the
feature/ff8-vibration-option-in-main-menu
branch
from
d7d1ac5
to
5ea2924
Compare
Done! |
julianxhokaxhiu
approved these changes
Feb 25, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bring back Vibration option in the main menu and the battle pause menu.
Motivation
The vibration option was restored only in field and worldmap pause menus. Since it is common that user want to disable vibration in battle, it is great to restore the original pause menu in battle too.
ACKs
Images
ePSXe french
FFNx french enabled
FFNx french disabled (keyboard or gamepad without rumble capability)