Music: Add new relative_speed option in the config layer #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myst6re
force-pushed
the
feature/config-change-music-speed
branch
from
abd6139
to
17bf1bc
Compare
myst6re
force-pushed
the
feature/config-change-music-speed
branch
from
17bf1bc
to
3296b5b
Compare
julianxhokaxhiu
previously approved these changes
Mar 3, 2024
myst6re
force-pushed
the
feature/config-change-music-speed
branch
from
3296b5b
to
fcb7497
Compare
julianxhokaxhiu
approved these changes
Mar 3, 2024
julianxhokaxhiu
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
External Music: ability to set music speed via config
Motivation
Kurodo asked me if it was possible to sync "tb" music track (main theme alternative / Cloud's mind) with the scene, like in PS1
https://www.youtube.com/watch?v=ELt0-heDj0I&t=20020s
The PC version is faster than the PSX version, one solution would be speed up the music. That's increase the pitch a little, I'm not a big fan of this solution. But everyone seems fine with it, for example the modder Postscriptthree released a fix that just does just that, DLPB also did this in the past.
Since this patch is really light, and can be used by modders for whetever creative reasons (I enjoy listening to the slow version of costa del sol, for example), so let's do it!
ACKs