Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF8: Battle effects external textures improvements #676

Merged
merged 1 commit into from
Mar 14, 2024
Merged

FF8: Battle effects external textures improvements #676

merged 1 commit into from
Mar 14, 2024

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Mar 14, 2024 •
edited

Summary

Some effects still have issues to get overriden correctly.

  • Doomtrain (and maybe some others): first texture is not named correctly, we use the filename of the last loaded weapon
  • Cerberus/Cactuar (and maybe some others): some textures are not dumped, because we don't have any palette
  • Carbuncle: We assumed that a tim file contains only one texture, that's not the case for Carbuncle
  • Effect Tims with multiple palettes: dump all the palettes

Motivation

To please digixu

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@myst6re myst6re force-pushed the feature/ff8-battle-effects-external-textures-improvements branch from a6fb4f7 to c0061f8 Compare March 14, 2024 12:17
@myst6re myst6re marked this pull request as ready for review March 14, 2024 12:18
@julianxhokaxhiu julianxhokaxhiu self-requested a review March 14, 2024 15:30
@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Mar 14, 2024
@julianxhokaxhiu julianxhokaxhiu added this to the 1.19.0 milestone Mar 14, 2024
@julianxhokaxhiu julianxhokaxhiu merged commit a7a6e01 into julianxhokaxhiu:master Mar 14, 2024
@julianxhokaxhiu
Copy link
Owner

Thank you, great motivation for this PR :D

@myst6re myst6re deleted the feature/ff8-battle-effects-external-textures-improvements branch March 14, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianxhokaxhiu julianxhokaxhiu julianxhokaxhiu approved these changes

Assignees

@myst6re myst6re

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@myst6re @julianxhokaxhiu