Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF7: Prevent input configuration corruption on Steam edition #683

Merged
merged 7 commits into from
Mar 31, 2024

Conversation

maciej-trebacz
Copy link
Contributor

Summary

Replaces the default config bitmask value from 0x41 to 0x45, which sets the default Controller type to "Customize" instead of "Normal" in FF7 Steam.

Motivation

FF7 Steam locks the Controller setting to "Customize" because the "Normal" control scheme is broken (it uses numpad controls). However there is a bug that can cause your config file to get corrupted and try to load the "Normal" control scheme anyways. This is because the config bitmask value that is loaded on New Game is initialized to 0x41 with the third bit responsible for switching from "Normal" to "Customize" not set.

This change patches this bitmask to set that bit on so the game always uses "Customize" control scheme.

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@maciej-trebacz maciej-trebacz changed the title Master Input: Prevent input configuration corruption on FF7 Steam Mar 31, 2024
@maciej-trebacz
Copy link
Contributor Author

maciej-trebacz commented Mar 31, 2024

Since I obviously don't know how to Git properly please squash this instead of a normal merge.

@julianxhokaxhiu julianxhokaxhiu self-requested a review March 31, 2024 19:50
@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Mar 31, 2024
@julianxhokaxhiu julianxhokaxhiu added this to the 1.19.0 milestone Mar 31, 2024
@julianxhokaxhiu julianxhokaxhiu changed the title Input: Prevent input configuration corruption on FF7 Steam FF7: Prevent input configuration corruption on Steam edition Mar 31, 2024
@julianxhokaxhiu julianxhokaxhiu merged commit 602cd14 into julianxhokaxhiu:master Mar 31, 2024
@julianxhokaxhiu
Copy link
Owner

Thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants