Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF8: Fix game over crash with external textures #686

Conversation

myst6re
Copy link
Contributor

@myst6re myst6re commented Apr 17, 2024

Summary

Ignore PNGs without alpha (for now)

Motivation

Converting PNGs adds a little overhead, it is not big, but we don't want to promote PNGs in mods

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@myst6re myst6re force-pushed the fix/ff8-game-over-crash-with-external-textures branch 2 times, most recently from ea693ee to 59ed11f Compare April 17, 2024 20:50
@myst6re
Copy link
Contributor Author

myst6re commented Apr 17, 2024

Ready

@myst6re myst6re force-pushed the fix/ff8-game-over-crash-with-external-textures branch from 59ed11f to 4eee0f6 Compare April 17, 2024 20:55
@myst6re myst6re force-pushed the fix/ff8-game-over-crash-with-external-textures branch from 4eee0f6 to b4d1e9b Compare April 17, 2024 20:59
@julianxhokaxhiu julianxhokaxhiu added the bug Something isn't working label Apr 17, 2024
@julianxhokaxhiu julianxhokaxhiu added this to the 1.19.1 milestone Apr 17, 2024
@julianxhokaxhiu julianxhokaxhiu merged commit b198d15 into julianxhokaxhiu:master Apr 17, 2024
@julianxhokaxhiu
Copy link
Owner

Thank you!

@myst6re myst6re deleted the fix/ff8-game-over-crash-with-external-textures branch April 17, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants