Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive tests #105

Open
vchuravy opened this issue Nov 5, 2018 · 7 comments
Open

Comprehensive tests #105

vchuravy opened this issue Nov 5, 2018 · 7 comments

Comments

@vchuravy
Copy link
Member

vchuravy commented Nov 5, 2018

One of the issues (and one that became even more apparent during the 1.0 transistion) is that it is really hard to test this package.
Without CI development is slow since we are likely to break use-cases that we can't test.

Ideally we could use docker environments to instantiate a "minimal" cluster environment in which we then can run tests.

As an example see:

@lesteve
Copy link

lesteve commented Feb 2, 2019

You may be interested to borrow from the CI set-up (based on docker-compose) we have in dask-jobqueue (deploy dask on HPC clusters). For now, we have CI for SGE, PBS and SLURM.

@vchuravy
Copy link
Member Author

Oh that is rather interesting! I see you are running it on travis.

@simonbyrne
Copy link
Member

I managed to set up Travis testing on SlurmTools.jl using the docker images built by PySlurm:
https://github.com/simonbyrne/SlurmTools.jl/blob/master/.travis.yml

@kleinhenz
Copy link

I was also able to setup testing infrastructure on travis for SlurmClusterManager using docker-compose to create a small cluster. It seems to work pretty well.

@juliohm
Copy link
Collaborator

juliohm commented Oct 6, 2020

It would be nice to unite these efforts here. We all need cluster managers and yet the current state of affairs is quite fragmented for a reliable experience with testing, etc.

simonbyrne added a commit that referenced this issue Nov 25, 2020
simonbyrne added a commit that referenced this issue Nov 25, 2020
simonbyrne added a commit that referenced this issue Oct 7, 2021
* Add Slurm Docker tests

Start on #105, alternative to #125

Uses container from https://github.com/giovtorres/docker-centos7-slurm

* test more combinations

* sbatch output
@MilesCranmer
Copy link
Collaborator

Status of this? Is there still only slurm testing? Seems like PBS and SGE have been broken for a while: #179

@MilesCranmer
Copy link
Collaborator

WIP PR for this: #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants