Skip to content
This repository has been archived by the owner on Aug 14, 2021. It is now read-only.

beliefUpdateParticle in module #21

Closed
zsunberg opened this issue Aug 7, 2017 · 5 comments · Fixed by #24
Closed

beliefUpdateParticle in module #21

zsunberg opened this issue Aug 7, 2017 · 5 comments · Fixed by #24

Comments

@zsunberg
Copy link
Member

zsunberg commented Aug 7, 2017

Should beliefUpdateParticle.jl be included in the module so that it's easier to use? Right now the file has to be included explicitly to be accessed.

Happy to submit a PR if you agree with this, @ebalaban

@ebalaban
Copy link
Contributor

ebalaban commented Aug 8, 2017

I originally kept it separate with the thought of eventually implementing different types of belief updaters. That has not happened yet. Might as well put it in the module for now. If different belief updaters are ever developed, we can move it out (or still keep it there as the default updater). Feel free to submit a PR.

@zsunberg
Copy link
Member Author

zsunberg commented Aug 8, 2017

Ok, will do. There are alternative belief updaters out there, e.g. ParticleFilters.jl. It might actually be better from a maintenance perspective if one of those was the default, but I will just put beliefUpdateParticle in for now.

@ebalaban
Copy link
Contributor

ebalaban commented Aug 9, 2017

@zsunberg, the build on the PR was failing because MCTS was not being found. I added MCTS to REQUIRE, but that did not solve the problem. Any ideas why this may be happening?

@zsunberg
Copy link
Member Author

zsunberg commented Aug 9, 2017 via email

@ebalaban
Copy link
Contributor

ebalaban commented Aug 9, 2017

Thanks, I thought this might be the case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants