Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to run the unit tests on CompatHelper PRs? #496

Closed
sloisel opened this issue Jun 3, 2024 · 2 comments
Closed

How to run the unit tests on CompatHelper PRs? #496

sloisel opened this issue Jun 3, 2024 · 2 comments

Comments

@sloisel
Copy link

sloisel commented Jun 3, 2024

Hello,

I've run CompatHelper on my project here and this is one of the PRs. It contains the following message:

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

I thought I had set up my github workflows so that it would run tests on pull requests, but I'm not seeing any tests on these pull requests.

How do I get CompatHelper to make me a pull request that is self-contained, and has the result of the unit tests already in it?

Edit: I do have a DOCUMENTER_KEY in my "Secrets", and there's a "Documenter" with "read/write" under "Deploy Keys".

Thanks,

S

@mattBrzezinski
Copy link
Member

You have a CI workflow that seems to run tests,

However when you look on the Actions page for recent runs, it only executes on main,

@sloisel
Copy link
Author

sloisel commented Jun 3, 2024

I had tried to make it run on all branches, see this commit, and I was able to manually trigger it, but it never ran from CompatHelper.

I spent a bit too much effort on this and I felt like it wasn't a big payoff so I've disabled CompatHelper for the time being...

@sloisel sloisel closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants