-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What to do after renaming a package? #4917
Comments
It is fine. At some point people will decide to to check for a new update, You could be like FiniteDifferences.jl and list the old name in the readme Making it error for no reason doesn't seem useful. |
Thanks, good to know that I'm on the right track.
I was proposing to print an error-level (or warn-level) log message, rather than throwing an error. As this would be done only once at the import time, I think it does not disturb standard usage (hence can be done with a minor version bump). I don't think it is a crazy idea to implement a way to discourage installing a package or a particular version of a package. For example, Python devs are doing similar discussion: PEP 592: Support for "Yanked" Files in the Simple Repository API - Packaging - Discussions on Python.org |
shrug logging a warning is permitted, yes. |
Well, being annoying is kind of a purpose of
Maybe that's from precompilation? Maybe logging message in I think yanking releases need properly handled by Pkg without an annoying hack like this. But I guess I should open it in Pkg instead. |
Aside: I don't think you are using the work Yank the same way Pkg/the registry uses it. You don't want to remove the old release do you? |
I'm using it in PEP 592 sense. I didn't know that |
Pkg's yank is similar to cargo yank (https://doc.rust-lang.org/cargo/reference/publishing.html#managing-a-cratesio-based-crate) but looks like python yank is similar. |
JuliaLang/Pkg.jl#726 for reference |
Thanks, I think yank implemented in Pkg does what I want. |
Closing, due to #5000 (comment) |
I moved my package from https://github.com/tkf/ProgressMeterLogging.jl to https://github.com/tkf/ConsoleProgressMonitor.jl and re-registered it with a different UUID. ProgressMeterLogging is still installable presumably because github redirects the old repository to the new one. I renamed old tags so the old release of ProgressMeterLogging.jl is "rooted" (and it's accessible via
ConsoleProgressMonitor#master
anyway).But are there any other actions I should take after re-registration? In particular:
Should I re-create the old repository (https://github.com/tkf/ProgressMeterLogging.jl) with all the releases? (and maybe archive it afterward.)
Is there any recommended way to discourage people from installing the old package? Ideally,
Pkg.add
should fail and it should not be listed in pkg.julialang.org (although it looks like it hasn't been updated for a while ATM). An approximation I can implement is to recommend installing the new package via@error
in__init__
of the old package.The text was updated successfully, but these errors were encountered: