Fix tests for corrected tokenize_skip_ngrams() #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two failing tests caused by an imminent release of v0.2 of the tokenizers package. The version 0.1.4 of the tokenizers package currently on CRAN has an incorrect implementation of skip n-grams. (See this issue for details.) The master branch of tokenizers has a fix. As a result the indices used in the tests are now incorrect and I have updated them.
Note that
tokenize_skip_ngrams()
now returns vastly more tokens, which is how it is supposed to work, but which might come as a surprise.