Resolves #168: reorder_within multiple variables #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much @tmastny; looks fantastic! 🙏 |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good evening! I'm making the change discussed here: #168 (comment).
This PR will change the
withinparameter ofreorder_withinto allow a list of vectors, so you can properly reorder factors when faceting by multiple variables. This change should not be breaking.I added two tests, following the format of the existing ones. For the
vdiffrtest, I added a graph that required reordering within multiple variables to be ordered correctly within each facet.I ran the tests and R CMD Check locally and everything passed.
Let me know if there is anything else you'd like to see.
Thanks for the great package!