-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make coordinate library #28
Make coordinate library #28
Conversation
This PR incorporates the Natural Extension Reference Frame (NeRF) algorithm to place new coordinates in the reference space given a Thanks to @RobertVernon for placing the math initially, here I have cleaned it, document it and implemented the tests. @AlaaShamandy @RobertVernon please review and accept for Merge. This PR aids on completing #27. |
src/idpconfgen/libs/libcalc.py
Outdated
@@ -88,10 +90,10 @@ def RT_to_plane(A, B, C):# PARENT, XAXIS, PLANE | |||
|
|||
v = AXIS_111 | |||
|
|||
return np.dot(b, v), A | |||
return np.dot(b, v) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll note that this means the function is no longer "RT_to_plane"
(RT is the shorthand for a pair of Rotation + Translation objects)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comment!
Thanks for your review @AlaaShamandy . |
* np.dot(v,b) corrected to np.dot(v,b).T * added additional tests * Closes #31
@RobertVernon @AlaaShamandy this PR is ready for review and merge. Please share your comments |
Thx @RobertVernon and @AlaaShamandy for your comments. We can have this merge now:
|
Make coordinate library
Addresses #27
I am currently working on this implementation. I create now this PR so that @AlaaShamandy @RobertVernon can easily follow the progression in real time. Parallel work is taking place at #23.