Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Public API Reform] Remove static setters setMaxParseIteration / setMaxVoteNumber #164

Open
julien-boudry opened this issue Jul 11, 2023 · 1 comment
Open

[Public API Reform] Remove static setters setMaxParseIteration / setMaxVoteNumber #164

julien-boudry opened this issue Jul 11, 2023 · 1 comment
Assignees
@julien-boudry
Labels
public api reform Mostly breaking change proposal for a better and consitent public api suggestion

Comments

@julien-boudry
Copy link
Owner

Context

Too much code

Proposal

Remove static setters Election::setMaxParseIteration() / Election::setMaxVoteNumber()
Use typed static properties instead. They are public since v4.5.

Breaking changes

Yes
@julien-boudry julien-boudry added suggestion public api reform Mostly breaking change proposal for a better and consitent public api labels Jul 11, 2023
@julien-boudry julien-boudry self-assigned this Jul 11, 2023
@LiamM32
Copy link
Collaborator

LiamM32 commented Jul 14, 2023

I don't have any personal plans to use either of these functions. But that's all I have to comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julien-boudry julien-boudry

Labels
public api reform Mostly breaking change proposal for a better and consitent public api suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julien-boudry @LiamM32