Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test code - 'isMariaDB' #409

Merged
merged 1 commit into from Jul 29, 2023

Conversation

chungeun-choi
Copy link
Contributor

@chungeun-choi chungeun-choi commented Jul 25, 2023

The result value executed through the fechone() function is passed in the form of a tuple, but the syntax to compare isMariaDB function always has an error that returns False because it checks for string type data

  • before code block (pymysqlreplication/tests/base.py)
    def isMariaDB(self):
        if self.__is_mariaDB is None:
            self.__is_mariaDB = "MariaDB" in self.execute("SELECT VERSION()").fetchone()
        return self.__is_mariaDB
  • image
    image

  • fixed
    Change to see the first element in the tuple lookup list

@chungeun-choi chungeun-choi changed the title Fix isMariaDB function error Fix 'isMariaDB function' error Jul 25, 2023
@chungeun-choi chungeun-choi reopened this Jul 25, 2023
@chungeun-choi chungeun-choi changed the title Fix 'isMariaDB function' error Fix test code - 'isMariaDB' Jul 29, 2023
@chungeun-choi
Copy link
Contributor Author

I changed the contents and opened it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants