Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developed the Mariadbannotate ros event #412

Conversation

chungeun-choi
Copy link
Contributor

mariadb-annotate-rows-event

1. Development of 'MariadbAnnotateRowsEvent'

2. Changes to the Binlogstream Object for MariaDB Replication

  • Updated the isMariadb field to check for MariaDB and set the 'mariadb settings' (__set_mariadb_settings) accordingly.

    • Previous behavior: Only checked if the auto_position field existed for MariaDB detection.
    • Updated behavior: Now detects MariaDB even if the auto_position field is not specified.
    • [link to the source code]
  • Added the annotate_rows_event field to enable the specific feature.

3. Test code

@chungeun-choi chungeun-choi changed the title to develop Mariadb annotate rows event To develop Mariadb annotate rows event Jul 29, 2023
@chungeun-choi chungeun-choi changed the title To develop Mariadb annotate rows event Developed the Mariadbannotate ros event Jul 29, 2023
@dongwook-chan
Copy link
Collaborator

As of MariaDB 10.2.4, the binlog-annotate-row-events is enabled by default, with query strings recorded in the ANNOTATE_ROWS_EVENT. This enhances utility of replication data for users and opens up many use case possibilities. However, given that this event precedes every row event, it may lead to an overload if DML is frequent. But the option for clients to receive this data by adjusting the BinLogStreamReader's annotate_rows_event argument mitigates this. In essence, this implementation is crucial to fully leverage the updated system variable's default value.

@julien-duponchelle julien-duponchelle merged commit c40f6f4 into julien-duponchelle:main Aug 20, 2023
4 checks passed
@julien-duponchelle
Copy link
Owner

Thanks !

@chungeun-choi
Copy link
Contributor Author

I am happy to contribute to the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants