Refactor/docker compose anchors #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lle#410 - `log_slave_updates` modifies to which file binlog events is written. - The variable is not applicable to python-mysql-replication, because no file is written
…roved readability and expandability Changes: - Updated version to 3.4 at which extension for docker compose was first introduced - Use extension to hold common fields and anchors to reference the extensions
…23-OSSCA-python-mysql-replication/python-mysql-replication into refactor/docker-compose-anchors
|
Indeed much better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the existing Docker Compose configuration to use YAML anchors and Docker Compose extensions. This enhances the maintainability and readability of the Docker Compose file, especially when adding new MySQL services to test various MySQL versions.
Changes
Leveraged YAML anchors for common service attributes
Used Docker Compose extensions to reduce redundancy
Modify Docker Compose to mitigate errors in previous tests
Benefits
Makes it easier to add new MySQL versions for testing without redundant code
Maintainability: Centralizes common configuration elements, making future updates more straightforward
Makes the docker-compose.yml file more readable and easier to understand
How to Test