Fix GitHub Actions Failure by Updating Test Code for PreviousGtidsEvent #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: cucuridas <3310223@naver.com>
|
Oh right I solved conflicts by hand and didn't pay attention thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreviousGtidsEvent was recently added to the codebase, but the corresponding test cases in the TestBasicBinLogStreamReader class were not updated. This has been causing GitHub Actions to fail.
This PR fixes the issue by updating the test_allowed_event_list method in TestBasicBinLogStreamReader to include the correct expected lengths for _allowed_event_list.
Before the fix, the test expected lengths of 23, 22, and 22 for different scenarios. These have been corrected to 24, 23, and 23, respectively, to align with the addition of PreviousGtidsEvent.