better error message when importing a Splitwise csv #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #216
When importing a csv from a non English Splitwise account it errors with
Malformed CSV, impossible to find the column namesThis PR makes the error a bit better by telling the users what to do to get unblocked.
It's my first contribution here, any tips for this PR? Especially on how to do the localization?
It seems there are a lot of places to be updated https://github.com/search?q=repo%3Ajulien-nc%2Fcospend-nc+%22Malformed+CSV%2C+impossible+to+find+the+column+names%22&type=code