refs #12 fix default param value on non-terminal-position param

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc · Feb 2, 2023 · 7fc121f · 7fc121f
1 parent 30f508e
commit 7fc121f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/Controller/PageController.php b/lib/Controller/PageController.php
@@ -965,7 +965,7 @@ public function getTrackMarkersJson(int $id, string $directoryPath, bool $proces
 			$tracksById[$jsonTrack['id']] = $jsonTrack;
 		}
 
-		$picturesArray = $this->processService->getGeoPicsFromFolder($this->userId, $directoryPath, false, $id);
+		$picturesArray = $this->processService->getGeoPicsFromFolder($this->userId, $directoryPath, $id, false);
 
 		return new DataResponse([
 			'tracks' => $tracksById,

diff --git a/lib/Service/ProcessService.php b/lib/Service/ProcessService.php
@@ -792,15 +792,16 @@ private function getElevationGainLoss($points) {
 	 *
 	 * @param string $userId
 	 * @param string $subfolder
+	 * @param int $directoryId
 	 * @param bool $recursive
 	 * @return array
 	 * @throws Exception
 	 * @throws InvalidPathException
+	 * @throws NoUserException
 	 * @throws NotFoundException
 	 * @throws NotPermittedException
-	 * @throws NoUserException
 	 */
-	public function getGeoPicsFromFolder(string $userId, string $subfolder, bool $recursive = false, int $directoryId): array {
+	public function getGeoPicsFromFolder(string $userId, string $subfolder, int $directoryId, bool $recursive = false): array {
 		if (!function_exists('exif_read_data')) {
 			return [];
 		}