Fix arguments starting with "-" being unrecognized #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug that causes arguments starting with "-" to not be recognized
|
Thanks a lot @iRath96 ! Could you add a test to validate your PR please if that's not too complicated? |
Add test case for arguments starting with a dash.
|
@julienXX Added the test case. Let me know if there's anything else you need :) |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this amazing gem!
I recently ran into an issue that when passing arguments (like text, title or subtitle) that start with a "-", no notification would be displayed. I traced this bug down to NSUserDefaults, which doesn't like arguments like
-title "-xyz"apparently. This PR implements a hack to get around this by inserting a space before such arguments (-title "-xyz"becomes-title " -xyz"). MacOS removes whitespace, so notifications are shown correctly (without the space) in the notification center.