Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for Turbo Drive (Breaking Change) #26

Merged
merged 1 commit into from Mar 30, 2024

Conversation

julienbourdeau
Copy link
Owner

Loading the javascript inside the body caused it to be re-executed when using Turbo Drive navigation.

CleanShot 2024-03-30 at 11 52 24@2x

The #__debugbar element uses data-turbo-permanent to not be reloaded, see #25

And the js file is loaded inside the head element.
I'm a little bit scared that it doesn't work well if the js is loaded before #__debugbar exists in the dom 馃

The debugbar_javascript helper is now split into 2 helpers:

  • debugbar_head for the
  • debugbar_body for the

@julienbourdeau julienbourdeau merged commit 6f7fc11 into master Mar 30, 2024
@julienbourdeau julienbourdeau deleted the feat/turbo-drive branch March 30, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant