Exclude method OPTIONS in the list of supported request methods #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return false; | ||
| } | ||
|
|
||
| if (isset($regex['uri']) && $regex['uri'] && preg_match($regex['uri'], $route->uri)) { | ||
| return false; | ||
| } | ||
|
|
||
| // Lets exclude OPTIONS in the list of methods supported | ||
| if (Str::is($event->request->getMethod(), 'OPTIONS')) { |
| @@ -33,15 +34,21 @@ protected function shouldLogUsage($event) | |||
|
|
|||
| $route = $event->request->route(); | |||
| $regex = config('route-usage.excluding-regex'); | |||
| $name = method_exists($route, 'getName') ? $route->getName() : null; | |||
There was a problem hiding this comment.
Can you explain when this method would not be defined?
|
Thanks for your contributions! 👍 |
|
Could you remove the dependency on <?php $event->request->isMethod('options'); ?> |
|
Good idea. It's also more readable. Any reason why you want to remove the dependency to Str (since this package only works with Laravel anyway)? |
|
@julienbourdeau None in particular, other than it could read a little better as you've said, and as it's on the request object Laravel will already be handling bizarre edge cases (if there are any?) |
|
@ingalless @harlekoy In the end, I went for #12. Thanks for the suggestions and ideas 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.