-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable date format #20
Configurable date format #20
Conversation
Hi @rogervila, |
Hey @julienbourdeau, congratulations!! :) If you find something that must be changed tell me and I'll update the PR. |
Hi @rogervila, Thanks a lot for your patience 😅 I didn't think this date format would be an issue. I definitely like your PR 👍 I'm going to merge it as-is but I think I'll make a few changes before tagging a version. I'd like to avoid having default values different places. I need to check how configuraiton is merged. |
So Laravel don't seem to merge configurations so I think it's great, I'll just leave it this way 👍 Thanks! |
Hey! Thank you for merging @julienbourdeau |
When using SQLServer I get a Carbon exception related to the date format.
This Pull Request adds the ability to specify the date format on the configuration, in order to avoid this error.
This is the full log in case you find it useful.