Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slicing #8

Merged
merged 3 commits into from
Sep 17, 2018
Merged

Fix slicing #8

merged 3 commits into from
Sep 17, 2018

Conversation

julienr
Copy link
Owner

@julienr julienr commented Sep 17, 2018

No description provided.

@julienr
Move merge_close_vertices from example to meshcut
24e18ee
@julienr
Fix an issue when two triangle share 2 vertices that are on the plane.
4480b32 
  2
 /  \
1 - -3
 \  /
   4

In this situation, the previous implementation could start from triangle
(1, 2, 3), visit vertex 1, use the triangle (1, 3, 4) as the next triangle
and then visit vertex 3 and pick the initial triangle again, at which
point it would stop thinking it has been around the mesh.

This issue happen only when two triangles share two vertices that lie
exactly on the plane (so both triangles have the same set of intersections
with the plane).

The solution is that once we have visited a triangle and chosed the next
one from its neighbours, we remove all neighbouring triangles from the
‘to-visit’ list. This ensure we never go back to a previously visited
triangle.

Closes #7
@julienr julienr force-pushed the fix_slicing branch 3 times, most recently from 43fcda3 to b02294a Compare September 17, 2018 20:22
@julienr julienr merged commit 7116aaa into master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@julienr