Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: ServeFiles and BasicAuth #290

Open
mvasi90 opened this issue Dec 14, 2019 · 0 comments
Open

Proposal: ServeFiles and BasicAuth #290

mvasi90 opened this issue Dec 14, 2019 · 0 comments

Comments

@mvasi90
Copy link

mvasi90 commented Dec 14, 2019

Hello,

Please add another function to ServeFiles with BasicAuth

router.ServeFiles("/static/*filepath", http.FileSystem(http.Dir(staticFolder)))

compatible with this:

router.GET("/", BasicAuth(Index, user, pass))

to avoid two different middleware.
similark pushed a commit to similarweb/httprouter that referenced this issue May 9, 2023
@arschles
removing double sleep in scaler handler test (julienschmidt#290)
4c61fae 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvasi90