Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling needed when requesting full hashes fails #7

Closed
papaiatis opened this issue Jun 28, 2017 · 1 comment
Closed

Better error handling needed when requesting full hashes fails #7

papaiatis opened this issue Jun 28, 2017 · 1 comment
Assignees
@geever
Labels
enhancement

Comments

@papaiatis
Copy link
Contributor

When I call $gsb->lookup(...) sometimes I see this message in the logs: Full hash request failed but my client software keeps working because the lookup method returns an empty array back, thus I don't really have the chance to catch this error.

I would expect this method to either throw an exception or return back an error flag in cases of this.
@geever geever self-assigned this Jun 28, 2017
juliensobrier added a commit that referenced this issue Aug 17, 2017
@juliensobrier
issue #7 Update last_error when full has request fails
55fdaf6
@juliensobrier
Copy link
Owner

last_error is now updated when the full hash request fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geever geever

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juliensobrier @geever @papaiatis