-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration file for Django>=1.7 #21
Conversation
Any chance of getting this added please? |
Is there a way this could break/affect users using Django<1.7? |
Not that I'm aware of. However, since 1.7 is the longest version that is no supported officially I don't think that's an issue personally. In my mind it would be much better to support people using 1.7 onwards by having the migration files in there so that people don't have to try and debug an error when using this great package. |
+1, please include migrations so we can use this package with newer versions of django :) |
Sorry I've taken forever. Would you mind regenerating the migration for it to be up to date with the latest changes? |
Would it be possible to merge this soon and publish a new release? This would help us (and others) avoid the hassle of having a local migration for this app. |
The main problem with this is that the I see in the migration file there is # chunked_upload/migrations/0001_initial.py
from .settings import ABSTRACT_MODEL
# ...
class Migration(migrations.Migration):
# ...
options={
'abstract': ABSTRACT_MODEL,
}, |
name='ChunkedUpload', | ||
fields=[ | ||
('id', models.AutoField(auto_created=True, primary_key=True, serialize=False, verbose_name='ID')), | ||
('upload_id', models.CharField(default=chunked_upload.models.generate_upload_id, editable=False, max_length=32, unique=True)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be default=chunked_upload.settings.UPLOAD_TO
Would really like a fix to this issue :) |
It looks like using |
This change was done in #53 |
No description provided.